-
Notifications
You must be signed in to change notification settings - Fork 662
[DO NOT MERGE] Upgraded Gradle version to 9.0.0 #3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
04b0737 to
1d3689f
Compare
|
New limitation: minimal JVM version is 17 |
| }) | ||
| // TODO fix the migration issue | ||
| // source(compileTask.map { | ||
| // @Suppress("INVISIBLE_MEMBER") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tapchicoma, could you please help with fixing this problem?
| it.commonSourceSet | ||
| }) | ||
| // TODO fix the migration issue | ||
| // @Suppress("INVISIBLE_MEMBER") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
| val generator: TaskProvider<Task?> = null | ||
| setModuleDescriptorGenerator(generator) | ||
| // TODO fix the migration issue | ||
| // @Suppress("NULL_FOR_NONNULL_TYPE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
|
@Tapchicoma PTAL |
| @@ -1,11 +1,11 @@ | |||
| [versions] | |||
| kotlin = "2.2.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest first updating this repo to Kotlin 2.2.21, as it contains an important fix for Gradle 9.0.0 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
However, the problems with Java modularity are not due to Gradle compatibility - they are due to using the outdated KGP API and I'm not aware how to correct them correctly.
And one problem is that @Suppress("NULL_FOR_NONNULL_TYPE") does not work in K2 - perhaps there are also ready-made solutions here on how to do this in a different way.
No description provided.